Replace example.com domains with Scrapinghub demo toscrape.com domains in the documentation #149
Conversation
…s in the documentation
|
I am little concerned that the changes may dilute the context or the relevance of the examples. Need a second opinion on this. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 85.39% 85.39%
=======================================
Files 14 14
Lines 815 815
=======================================
Hits 696 696
Misses 119 119 |
|
I am checking the tox ci/cd failure |
| @@ -62,7 +62,7 @@ Suppose we have the following Page Object: | |||
|
|
|||
| # Simulates clicking on a button that says "View All Images" | |||
| response: web_poet.HttpResponse = await self.http.get( | |||
| f"https://api.example.com/v2/images?id={item['product_id']}" | |||
| f"https://api.toscrape.com/v2/images?id={item['product_id']}" | |||
There was a problem hiding this comment.
This is not a working URL; is it possible to have a real example? I think the idea to use toscrape.com domain is to actually make the examples runnable.
There was a problem hiding this comment.
I agree @kmike . Though, the situation here is that we do not have a toscrape.com website that supports API calls. Now there are websites that support dummy/test API calls but the mandate of the issue was that we should not be using other external domains.
Can we setup an API based toscrape website?
There was a problem hiding this comment.
Not sure how it fits the example, but I think http://quotes.toscrape.com/scroll uses an AJAX call.
Fixes #107