Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DummyResponse.replace is broken #99

Open
kmike opened this issue Dec 7, 2022 · 0 comments
Open

DummyResponse.replace is broken #99

kmike opened this issue Dec 7, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@kmike
Copy link
Member

kmike commented Dec 7, 2022

Currently DummyResponse only accepts url and request arguments. But the replace method (inherited from Response) passes all the attributes to __init__, which causes an exception.

I think we should support response.replace, because some middlewares might want to call it, and they expect it to work.

Most likely, a fix is a matter of removing DummyResponse.__init__ method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant