Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spider middlewares are not async compatible #72

Open
VMRuiz opened this issue Sep 13, 2023 · 0 comments
Open

Spider middlewares are not async compatible #72

VMRuiz opened this issue Sep 13, 2023 · 0 comments

Comments

@VMRuiz
Copy link
Contributor

VMRuiz commented Sep 13, 2023

This library defines several middlewares that are added by default to all jobs running on Scrapycloud. People wanting to use async spider middlewares may face issues as described here

My proposal is to add async compatibility by implementing process_spider_output_async method as per docs to avoid such issues while keeping compatibility with previous versions. Alternatively, they could be converted into fully async middlewares limiting the futures releases of the library to Scrapy >=2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant