Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize SDF files as opposed to dynamic spawning #22

Open
Tracked by #26
mabelzhang opened this issue Mar 29, 2024 · 0 comments
Open
Tracked by #26

Parameterize SDF files as opposed to dynamic spawning #22

mabelzhang opened this issue Mar 29, 2024 · 0 comments

Comments

@mabelzhang
Copy link
Contributor

mabelzhang commented Mar 29, 2024

Currently, worlds are dynamically spawned in the test code (e.g. boxes.hh, boxes_dt.cc, boxes_model_count.cc).
This couples world definitions to simulator-dependent tests.

To allow tests to be created for other simulators, the world definitions should be decoupled from the test code.
Ideally, the worlds should be defined in documentation, which is then implemented for each simulator. This could be in SDF, if multiple simulators are able to load SDF files, or in different file formats suitable for each simulator.

What parameters to choose:
For future extension to other simulators, it may be useful to have two sets of parameters for some or all of the tests.
Default: There should be a default set of parameters, which is not overfit to tuned parameters for any particular simulator or test.
Best case: A "best case" set of parameters can be optimized for each simulator / physics engine.

Starting point: the world is partially parameterized in https://github.com/scpeters/benchmark/blob/master/worlds/boxes.world.erb
See boxes.hh for other parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant