Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Spec coverage for Hyrax::Resource with dynamic loading need to be written #20

Closed
1 task
Tracked by #6830
, #1 ,  #5
...
ShanaLMoore opened this issue Jun 7, 2024 · 4 comments
Closed
1 task
Tracked by #6830
, #1 ,  #5
...

✅ Spec coverage for Hyrax::Resource with dynamic loading need to be written #20

ShanaLMoore opened this issue Jun 7, 2024 · 4 comments
Labels
allinson flex amigos hyrax prime

Comments

@ShanaLMoore
Copy link

ShanaLMoore commented Jun 7, 2024 •
edited
Loading

Summary

Add specs that covers dynamic loading for Hyrax::Resource

Parent Ticket

Base work off of the WIP PR

Acceptance Criteria

  • Changes to Hyrax::Resource has spec coverage for dynamic loading

Screenshots or Video

Testing Instructions

Notes
@ShanaLMoore ShanaLMoore mentioned this issue Jun 7, 2024
Closed
8 tasks
This was referenced Jun 7, 2024
Draft
Open
@ShanaLMoore ShanaLMoore changed the title Spec coverage for Hyrax::Resource with dynamic loading need to be written ✅ Spec coverage for Hyrax::Resource with dynamic loading need to be written Jun 7, 2024
@ShanaLMoore
Copy link
Author

ShanaLMoore commented Jun 10, 2024 •
edited
Loading

This will test that the module is included. ✅

We also need to test the module itself.

ShanaLMoore added a commit to samvera/hyrax that referenced this issue Jun 11, 2024
@ShanaLMoore
✅ test that Hyrax::Flexibility module is included
6209db7 
In this commit, we test that a module is included when the HYRAX_FLEXIBLE env var is set.
Issue:
- scientist-softserv/amigos#20
@github-project-automation github-project-automation bot moved this to Done in Amigos Jun 11, 2024
@ShanaLMoore ShanaLMoore reopened this Jun 14, 2024
@github-project-automation github-project-automation bot moved this from Done to Ready for Development in Amigos Jun 14, 2024
@ShanaLMoore
Copy link
Author

ShanaLMoore commented Jun 14, 2024 •
edited
Loading

TODO: since Rob was still developing, please recheck the coverage is adequate cc @kirkkwang

@kirkkwang
Copy link

Handled in this commit samvera/hyrax@44b75f9

@github-project-automation github-project-automation bot moved this from Ready for Development to Done in Amigos Jun 17, 2024
@kirkkwang
Copy link

Reverted the spec in this commit samvera/hyrax@4275dbc

The spec was causing flaky issues and really felt unnecessary because it was simply testing an if statement

@kirkkwang kirkkwang mentioned this issue Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
allinson flex amigos hyrax prime
Projects
Amigos
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ShanaLMoore @kirkkwang