Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Specs for SchemaLoader need to be done #18

Closed
1 task
Tracked by #6830
, #1 ,  #5
...
ShanaLMoore opened this issue Jun 7, 2024 · 1 comment
Closed
1 task
Tracked by #6830
, #1 ,  #5
...

✅ Specs for SchemaLoader need to be done #18

ShanaLMoore opened this issue Jun 7, 2024 · 1 comment
Labels
allinson flex amigos hyrax prime

Comments

@ShanaLMoore
Copy link

ShanaLMoore commented Jun 7, 2024 •
edited by kirkkwang
Loading

Summary

The SimpleSchemaLoader and M3SchemaLoader were refactored to inherit from the SchemaLoader. Add specs for the Hyrax::SchemaLoader class and its children if applicable.

Parent Ticket

Base work off of the WIP PR

Acceptance Criteria

  • Hyrax::\SchemaLoader has spec coverage

Screenshots or Video

Testing Instructions

Notes
@ShanaLMoore ShanaLMoore mentioned this issue Jun 7, 2024
Closed
8 tasks
This was referenced Jun 7, 2024
Draft
Open
@ShanaLMoore ShanaLMoore changed the title Specs for M3SchemaLoader need to be done ✅ Specs for M3SchemaLoader need to be done Jun 7, 2024
@kirkkwang kirkkwang changed the title ✅ Specs for M3SchemaLoader need to be done ✅ Specs for SchemaLoader need to be done Jun 10, 2024
@kirkkwang
Copy link

Handled in this commit samvera/hyrax@44b75f9

@github-project-automation github-project-automation bot moved this to Done in Amigos Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
allinson flex amigos hyrax prime
Projects
Amigos
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ShanaLMoore @kirkkwang