Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport and milestone #23

Open
Carreau opened this issue Sep 25, 2017 · 34 comments
Open

Backport and milestone #23

Carreau opened this issue Sep 25, 2017 · 34 comments

Comments

@Carreau
Copy link
Contributor

Carreau commented Sep 25, 2017

@choldgraf and @tacaswell, about auto backport:

What about a mini-language in milestone description, something in the milestone description(editable on GitHub) that tell the bots which branches to backport to; Something like:

- backport: v2.x

Allowing potentially multiple - backport: targets.

Thoughts ?

@choldgraf
Copy link
Collaborator

by auto-backport you mean behavior where users don't tell meeseeks to do anything? As soon as a PR is merged it automatically backports to other branches?

@Carreau
Copy link
Contributor Author

Carreau commented Oct 4, 2017

Yes

Basically if a PR is merged on master and has a milestone, MrMeeseeks will trigger the commands present in the Milestone Description.

It's actually implemented, I changed a a bit the way it work.
In the milestone description you can put lines that say:

on-merge: backport to v2.1.x
on-merge: say "Oh Weeeee"

And mr meeseeks would backport on the branch v2.1.x and say "Oh Weeeee"

For example https://github.com/MeeseeksBox/test1/milestones
even if "say" is not implemented yet.

@choldgraf
Copy link
Collaborator

choldgraf commented Oct 4, 2017 via email

@Carreau
Copy link
Contributor Author

Carreau commented Oct 4, 2017

@meeseeksdev say Oh Weee !!!

@lumberbot-app
Copy link
Contributor

lumberbot-app bot commented Oct 4, 2017

O h W e e e ! ! !

@choldgraf
Copy link
Collaborator

@meeseeksdev say Oooooooohhhhh yeeeahh

@Carreau
Copy link
Contributor Author

Carreau commented Oct 4, 2017

retry ? You can use say only if you have write permission.

@choldgraf
Copy link
Collaborator

@meeseeksdev say Oooooohhhh yeahhh!

@lumberbot-app
Copy link
Contributor

lumberbot-app bot commented Oct 4, 2017

Oooooohhhh yeahhh!

@choldgraf
Copy link
Collaborator

😍

@choldgraf
Copy link
Collaborator

@meeseeksdev say 💯

@lumberbot-app
Copy link
Contributor

lumberbot-app bot commented Oct 4, 2017

💯

@choldgraf
Copy link
Collaborator

hehe I think that confused it

@choldgraf
Copy link
Collaborator

@meeseeksdev say 😍

@lumberbot-app
Copy link
Contributor

lumberbot-app bot commented Oct 4, 2017

😍

@choldgraf
Copy link
Collaborator

@meeseeksdev say 🔢

@lumberbot-app
Copy link
Contributor

lumberbot-app bot commented Oct 4, 2017

🔢

@choldgraf
Copy link
Collaborator

@meeseeksdev say @meeseeksdev say oooohhhhhhhh

@lumberbot-app
Copy link
Contributor

lumberbot-app bot commented Oct 4, 2017

oooohhhhhhhh

@choldgraf
Copy link
Collaborator

damn!

@blink1073
Copy link
Collaborator

Y'all are making for a hilarious e-mail feed. 😜

@choldgraf
Copy link
Collaborator

lol mr meeseeks is going to cause so much more github noise

@choldgraf
Copy link
Collaborator

what do you think mr meeseeks?

@meeseeksdev say suuuuure thing chris!

@lumberbot-app
Copy link
Contributor

lumberbot-app bot commented Oct 4, 2017

suuuuure thing chris!

@Carreau
Copy link
Contributor Author

Carreau commented Oct 4, 2017

I'm considering allowing command in html comments to hide them :-)

@Carreau
Copy link
Contributor Author

Carreau commented Oct 4, 2017

Testing...

@lumberbot-app
Copy link
Contributor

lumberbot-app bot commented Oct 4, 2017

Oh Yeah that works !

@choldgraf
Copy link
Collaborator

choldgraf commented Oct 4, 2017

cool!

@lumberbot-app
Copy link
Contributor

lumberbot-app bot commented Oct 4, 2017

ooooohhhhhh weeee, who told me to say this? oh jeez I don't know!

@Carreau
Copy link
Contributor Author

Carreau commented Oct 4, 2017

@choldgraf please stop

@lumberbot-app
Copy link
Contributor

lumberbot-app bot commented Oct 4, 2017

Yeah Chris shut up.

@choldgraf
Copy link
Collaborator

lol you messed up your HTML hiding ;-)

@lumberbot-app
Copy link
Contributor

lumberbot-app bot commented Oct 4, 2017

yeah matthias, you need to add the ! in there 😝

@lumberbot-app
Copy link
Contributor

lumberbot-app bot commented Oct 4, 2017

yeah matthias, you need to add the ! in there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants