support older node.js versions

* don't use incompatible optionals syntax * add more old node.js versions to testing matrix
scarf-sh · Aug 11, 2023 · e9504b9 · e9504b9
1 parent 0196d2e
commit e9504b9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -9,7 +9,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x, 20.x]
+        node-version: [10.x, 12.x, 14.x, 18.x, 20.x]
 
     steps:
     - uses: actions/checkout@v2
@@ -30,7 +30,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x, 20.x]
+        node-version: [10.x, 12.x, 14.x, 18.x, 20.x]
 
     steps:
     - uses: actions/checkout@v2
@@ -51,7 +51,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x, 20.x]
+        node-version: [10.x, 12.x, 14.x, 18.x, 20.x]
 
     steps:
     - uses: actions/checkout@v2

diff --git a/report.js b/report.js
@@ -74,8 +74,10 @@ function skipTraversal (rootPackage) {
 }
 
 function parentIsRoot (dependencyToReport) {
-  return dependencyToReport?.parent?.name === dependencyToReport?.rootPackage?.name &&
-    dependencyToReport?.parent?.version === dependencyToReport?.rootPackage?.version
+  const parent = dependencyToReport.parent
+  const rootPackage = dependencyToReport.rootPackage
+
+  return parent && rootPackage && parent.name === rootPackage.name && parent.version === rootPackage.version
 }
 
 function isTopLevel (dependencyToReport) {