Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lb): health_check block #1988

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

feat(lb): health_check block #1988

wants to merge 3 commits into from

Conversation

Monitob
Copy link
Contributor

@Monitob Monitob commented Jun 14, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2023 •
edited
Loading

Codecov Report

Merging #1988 (8dbdca6) into master (a5f29dc) will decrease coverage by 0.01%.
The diff coverage is 75.64%.

@@            Coverage Diff             @@
##           master    #1988      +/-   ##
==========================================
- Coverage   74.04%   74.03%   -0.01%     
==========================================
  Files         182      182              
  Lines       28655    28906     +251     
==========================================
+ Hits        21217    21402     +185     
- Misses       5635     5690      +55     
- Partials     1803     1814      +11
Impacted Files Coverage Δ
scaleway/helpers_lb.go 78.60% <56.34%> (-6.25%) ⬇️
scaleway/resource_lb_backend.go 80.88% <92.41%> (+2.43%) ⬆️

@remyleone remyleone requested a review from yfodil June 15, 2023 07:22
remyleone
remyleone reviewed Jun 15, 2023
View reviewed changes
Copy link
Member

@remyleone remyleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this was started without a lot of agreement with the product team. Could we have a check with them and with @yfodil too?

scaleway/resource_lb_backend_test.go Show resolved Hide resolved
scaleway/resource_lb_backend_test.go
}
`,
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr("scaleway_lb_backend.bkd01", "health_check.#", "1"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that the health check in created

@Monitob Monitob self-assigned this Jun 16, 2023
@Monitob Monitob marked this pull request as draft June 16, 2023 08:41
@remyleone remyleone added load-balancer Load-balancer issues, bugs and feature requests priority:highest Bugs filled by customers, security issues enhancement labels Apr 10, 2024
@remyleone remyleone assigned yfodil and unassigned Monitob Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone left review comments

@yfodil yfodil yfodil approved these changes

Assignees

@yfodil yfodil

Labels
breaking-change enhancement load-balancer Load-balancer issues, bugs and feature requests priority:highest Bugs filled by customers, security issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Monitob @codecov-commenter @remyleone @yfodil