chore(mnq): migrate to github.com/aws/aws-sdk-go-v2 #2843
+19,802
−9,230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
mnq
jremy42
force-pushed
the
feat/Migrate_sqs_from_v1_to_v2
branch
from
64d4939 to
059d060
Compare
jremy42
changed the title
jremy42
force-pushed
the
feat/Migrate_sqs_from_v1_to_v2
branch
from
b3ad3dc to
0d3e400
Compare
jremy42
force-pushed
the
feat/Migrate_sqs_from_v1_to_v2
branch
from
0d3e400 to
9828642
Compare
remyleone
changed the title
jremy42
force-pushed
the
feat/Migrate_sqs_from_v1_to_v2
branch
from
78c9f1d to
84e1d20
Compare
remyleone
reviewed
Dec 11, 2024
| @@ -247,12 +244,12 @@ func ResourceMNQSQSQueueUpdate(ctx context.Context, d *schema.ResourceData, m in | |||
| return diag.FromErr(err) | |||
| } | |||
|
|
|||
| queue, err := transport.RetryWhenAWSErrCodeEquals(ctx, []string{sqs.ErrCodeQueueDoesNotExist}, &transport.RetryWhenConfig[*sqs.GetQueueUrlOutput]{ | |||
| queue, err := transport.RetryWhenAWSErrCodeEquals(ctx, []string{"AWS.SimpleQueueService.NonExistentQueue"}, &transport.RetryWhenConfig[*sqs.GetQueueUrlOutput]{ | |||
There was a problem hiding this comment.
This string is a constant, could it be defined at package level?
| if tfawserr.ErrCodeEquals(err, "AccessDeniedException") { | ||
| var apiErr *smithy.GenericAPIError | ||
| if errors.As(err, &apiErr) && apiErr.Code == "AccessDeniedException" { | ||
| // L'erreur AccessDenied signifie que la ressource est supprimée ou inaccessible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2836