Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary compatibility check when bumping scala version #1673

Closed
bjaglin opened this issue Sep 15, 2022 · 1 comment · Fixed by #1676
Closed

Fix binary compatibility check when bumping scala version #1673

bjaglin opened this issue Sep 15, 2022 · 1 comment · Fixed by #1676

Comments

@bjaglin
Copy link
Collaborator

bjaglin commented Sep 15, 2022

It seems that this is no longer enough

mimaPreviousArtifacts := {
val currentScalaFullV = scalaVersion.value
val previousScalaFullV =
PreviousScalaVersion.getOrElse(currentScalaFullV, currentScalaFullV)
val previousScalaVCrossName = CrossVersion(
crossVersion.value,
previousScalaFullV,
scalaBinaryVersion.value
).getOrElse(identity[String] _)(moduleName.value)
Set(
organizationName.value % previousScalaVCrossName % stableVersion.value
)
},
mimaDependencyResolution := {
// effectively reverts https://github.com/lightbend/mima/pull/508 since the
// Coursier resolution ignores/overrides the explicit scala full version set
// in mimaPreviousArtifacts
val ivy = sbt.Keys.ivySbt.value
IvyDependencyResolution(ivy.configuration)
},

https://github.com/scalacenter/scalafix/actions/runs/3059849584/jobs/4937701943#step:5:649

As a result, this is needed (and forgotten most of the times):

@bjaglin bjaglin mentioned this issue Sep 20, 2022
@bjaglin
Copy link
Collaborator Author

bjaglin commented Sep 20, 2022

The regression was introduced by #1565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant