Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive dependency error when upgrading to Scala 2.13.15 from 2.13.14 #217

Open
durban opened this issue Oct 5, 2024 · 4 comments

Comments

@durban
Copy link

durban commented Oct 5, 2024

When upgrading a cross-built project from Scala 2.13.14 to 2.13.15, there are some dependency errors reported by versionPolicyReportDependencyIssues. See for example here: https://github.com/durban/choam/actions/runs/11059425885/job/30727717814#step:24:4147

[error] Incompatibilities with dependencies of choam-skiplist:0.4.0
[error]   org.scala-js:scalajs-scalalib_2.13: incompatible version change from 2.13.14+1.16.0 to 2.13.15+1.16.0 (compatibility: strict semantic versioning)
[error] Incompatibilities with dependencies of choam-skiplist:0.4.1
[error]   org.scala-js:scalajs-scalalib_2.13: incompatible version change from 2.13.14+1.16.0 to 2.13.15+1.16.0 (compatibility: strict semantic versioning)

The error seems to be caused by org.scala-js:scalajs-scalalib_2.13, whose version is updated from 2.13.14+1.16.0 to 2.13.15+1.16.0. I believe this error is a false positive, as it's supposed to be backward compatible.

@julienrf
Copy link
Collaborator

julienrf commented Oct 6, 2024

Thank you @durban for reporting the issue.
@sjrd Could you please explain the versioning of Scala.js?

@sjrd
Copy link
Contributor

sjrd commented Oct 6, 2024

I think this is the best explanation:
scala-js/scala-js#4913 (comment)

@julienrf
Copy link
Collaborator

julienrf commented Oct 6, 2024

Thank you for the pointer. What would you recommend to do in sbt-version-policy?

@sjrd
Copy link
Contributor

sjrd commented Oct 6, 2024

This should be considered a compatible change, in this case.

That said, it may not be true for all libraries that have a version looking like that, so... I don't know what's best in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants