Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to cancel run and test #2030

Open
tgodzik opened this issue Apr 6, 2023 · 2 comments
Open

Allow to cancel run and test #2030

tgodzik opened this issue Apr 6, 2023 · 2 comments
Labels
difficulty / easy Any change that is easy to implement. task / run task / test
Milestone
Bloop 1.5.10

Comments

@tgodzik
Copy link
Contributor

tgodzik commented Apr 6, 2023

It' already possible to cancel debug session, however it's not possible to stop a running run or test. Since it's highly possible that ScalaCLI and Bloop will be used by scastie we need to provide support for such cancelation.
@tgodzik tgodzik added task / run task / test difficulty / easy Any change that is easy to implement. labels Apr 6, 2023
@tgodzik tgodzik added this to the Bloop v1.5.7 milestone Apr 6, 2023
@tgodzik tgodzik modified the milestones: Bloop v1.5.7, Bloop 1.5.10 Jul 12, 2023
@masonedmison
Copy link
Contributor

From what I can tell, this still needs to be done. If so, I'd be happy to take a stab at it. Also it appears that #2018 is a duplicate of this.

@tgodzik
Copy link
Contributor Author

tgodzik commented Jun 20, 2024

From what I can tell, this still needs to be done. If so, I'd be happy to take a stab at it. Also it appears that #2018 is a duplicate of this.

Sure! The entrypoint for run is in https://github.com/scalacenter/bloop/blob/main/frontend/src/main/scala/bloop/bsp/BloopBspServices.scala#L838

I would first confirm that indeed things are not cancellable, as far as I can see everything is in place to forward any cancel coming to the server to the actual process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty / easy Any change that is easy to implement. task / run task / test
Projects
None yet
Milestone
Bloop 1.5.10
Development

No branches or pull requests
2 participants
@tgodzik @masonedmison