Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-check if we still need to handle segment1IsValid && segment2IsValid in mergeGraph #8368

Open
fm3 opened this issue Jan 30, 2025 · 0 comments

Comments

@fm3
Copy link
Member

fm3 commented Jan 30, 2025

During #8367 we noticed that this check may be obsolete due to the agglomerates now always being looked up by segment id in the current mapping.

Maybe we can remove it? Should be double-checked.

Also, with the same justification, should we also duplicate the agglomerateGraph2.segments.contains(segmentId2) assertions for agglomerateGraph1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant