Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user bounding boxes and meshes rotate according to current transformations #8340

Open
MichaelBuessemeyer opened this issue Jan 20, 2025 · 2 comments

Comments

@MichaelBuessemeyer
Copy link
Contributor

MichaelBuessemeyer commented Jan 20, 2025

Context

WEBKNOSSOS support layer transformations. However, in case the active volume layer is transformed, the meshes do not transform with it. For consistency, this should be the case. Moreover, the user bounding boxes do not adapt to the currently natively rendered layers transformations like the skeleton layer.

This came up in PR: #8159 (comment)

Expected Behavior

When transformations are configured

  • Meshes should rotate together with their respective segmentation layer
  • User bounding boxes should rotate according to the currently natively rendered layer just like the skeleton layer.

Current Behavior

The transform settings have no effect to them.

Steps to Reproduce the bug

  1. Configure dataset rotation for a dataset (possible after Allow permanent dataset layer rotation in dataset settings #8159 is merged)
  2. Create an annotation for the dataset and load meshes and create bounding boxes
  3. Toggle the layer transforms and see that the meshes and bounding boxes do not rotate
@philippotto
Copy link
Member

Related:

  • ad-hoc meshing sends the transformed coordinates to the backend which does not work
  • clicking on a segment in the right sidebar jumps to incorrect position if the segment was registered in another coordinate system
    • segment positions should probably always be stored in an untransformed manner and then transformed when needed (similar to skeleton nodes)

@MichaelBuessemeyer
Copy link
Contributor Author

  • Moreover: the new rotation feature could be featured in the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants