Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port QArith #9

Open
sbp opened this issue Aug 18, 2017 · 2 comments
Open

Port QArith #9

sbp opened this issue Aug 18, 2017 · 2 comments

Comments

@sbp
Copy link
Owner

sbp commented Aug 18, 2017

Whilst I only envisaged porting the P, N, and Z arithmetics from Coq, it might be nice to go for full-on completion and port QArith too. I'm not sure what the type should be, but probably something like this:

record Biq where
  constructor Ratio
  numerator: Biz
  denominator: Bip

The constructor could be Rational instead of Ratio, though by convention it should really be MkBiq. Coq uses num and den for the field names. I don't like "num", but perhaps n and d, or numer and denom would be okay.

@sbp
Copy link
Owner Author

sbp commented Aug 18, 2017

Just to make things extra confusing, Coq also immediately defines a way to get the denominator as a positive Z, i.e. BizP in our nomenclature, which is then apparently used quite a lot.

@clayrat
Copy link
Collaborator

clayrat commented Aug 21, 2017

Sounds good, but we should probably finish P/N/Z first :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants