-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.7.1 on GitHub repo, v0.8.0 on PyPI #31
Comments
oh hmm, maybe I pushed something to pypi and didn't merge it |
Probably. There is only dc69c7d. You may wish to rebase master if you think that it is not a bad idea (and you can find the commits). |
Could you please merge your code back in here? There is still a version discrepancy between this repo and pypi.
|
I don't know what went on with that version, but it also reverts fixes from 0.7.1, so I would suggest pinning your versions to 0.7.1 |
I have The following code: from rest_framework.permissions import BasePermission
class CanChangeChild(BasePermission):
...
@action(
detail=True,
methods=["patch"],
serializer_class=UpdateProfilePictureSerializer,
permission_classes=[CanChangeChild],
)
def update_profile_picture(self, request, pk=None):
... raised the following error from Pylance:
After checking the types, I found this in _PermClassesParam = Sequence[Type[BasePermission]] However, the issue seems corrected in the master branch:
The fix was made in #40 on Jul 25, 2023: 2a44546#diff-311444d4598e5dbe12bf1c0dd49f2afbbb13dbdff781bedabeb638d5f99e4f94L93-L94 I tried pinning to Would it be possible, @sbdchd, to publish the latest |
should be fixed! |
Latest release on the GitHub repository seems to be v0.7.1. On PyPI, we have v0.8.0.
Does that matter?
The text was updated successfully, but these errors were encountered: