Choice palette for join and aggregator select #2104
anjakefala
started this conversation in
Show and tell
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
The following was shared by @saulpw as a comment on this issue. I wanted more people to see it as a discussion post. =)
@saulpw's text starts here:
Okay, so I repurposed the command palette for chooseAggregator and chooseJointype. There are only a couple of remaining uses of chooseOne but they are fairly minor (theme chooser, signal chooser for the procmgr, ibis sidebar chooser). The palette has been improved/changed in a couple of subtle ways, too:
With quick-select on the 0-9 number keys, you currently can't type options with numbers in them, e.g. the q3 aggregator. Also the individual percentile aggregators (e.g. p10) are removed from the aggregator choices; now you can only choose their whole quartile group (e.g. q10).
This and a few cosmetic issues aside, I believe this palette mechanism should be sufficient to replace the fancy chooser, so I'm going to close this issue for now. Please let me know how you like this new choosing mechanism, and open new issues for anything that needs to be changed.
Beta Was this translation helpful? Give feedback.
All reactions