Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert commits that introduced bugs #37

Open
patcon opened this issue Jul 3, 2022 · 0 comments · May be fixed by #38
Open

Revert commits that introduced bugs #37

patcon opened this issue Jul 3, 2022 · 0 comments · May be fixed by #38

Comments

@patcon
Copy link

patcon commented Jul 3, 2022

Describe the bug

This is a great sample repo!

But it seems that #20 and #21 introduced syntax from react-hook-form v7, which breaks the app -- #21 breaks validation of the first name field, and #20 prevents the app from even starting.

To Reproduce
Steps to reproduce the behavior for #20 (startup issue):

  1. Just try to yarn start, and it should fail.

Steps to reproduce the behavior for #20 (validation issue):

  1. Go to first step
  2. Focus and then blur the first name field
  3. Focus and then blur the last name field

Expected behavior
Both fields (since blank, but required) should display validation messages.

Observed behavior
First name field doesn't show validation error, but last name field does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant