Skip to content
This repository was archived by the owner on Mar 21, 2025. It is now read-only.

Commit 7fdc593

Browse files
authored
Clean up some logging messages (#212)
* Clean up some logging messages * Remove unnecessary function parameter * Remove unnecessary import
1 parent b753a5e commit 7fdc593

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

internal/app/pslive/routes/videostreams/proxied.go

+1-7
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import (
1212
"github.com/labstack/echo/v4"
1313
"github.com/paulbellamy/ratecounter"
1414
"github.com/pkg/errors"
15-
"github.com/sargassum-world/godest"
1615
"github.com/sargassum-world/godest/handling"
1716

1817
"github.com/sargassum-world/pslive/internal/clients/mjpeg"
@@ -83,10 +82,8 @@ func (h *Handlers) HandleExternalSourceFrameGet() echo.HandlerFunc {
8382
func externalSourceFrameSender(
8483
ss *mjpeg.StreamSender, annotated bool, quality int,
8584
fpsCounter *ratecounter.RateCounter, fpsPeriod float32,
86-
l godest.Logger,
8785
) handling.Consumer[videostreams.Frame] {
8886
return func(frame videostreams.Frame) (done bool, err error) {
89-
l.Debug("received frame from external source")
9087
if err = frame.Error(); err != nil {
9188
return false, errors.Wrapf(err, "error with video source")
9289
}
@@ -113,7 +110,6 @@ func externalSourceFrameSender(
113110
// TODO: implement image resizing
114111

115112
// Send output
116-
l.Debug("sending frame from external source")
117113
if err := handling.Except(
118114
ss.SendFrame(frame), context.Canceled, syscall.EPIPE,
119115
); err != nil {
@@ -156,7 +152,7 @@ func (h *Handlers) HandleExternalSourceStreamGet() echo.HandlerFunc {
156152
const quality = 50 // TODO: implement adaptive quality for min FPS
157153
if err := handling.Except(
158154
handling.Consume(ctx, frameBuffer, externalSourceFrameSender(
159-
ss, annotated, quality, fpsCounter, fpsPeriod, c.Logger(),
155+
ss, annotated, quality, fpsCounter, fpsPeriod,
160156
)),
161157
context.Canceled,
162158
); err != nil {
@@ -196,7 +192,6 @@ func (h *Handlers) HandleExternalSourcePub() videostreams.HandlerFunc {
196192
return handling.Except(
197193
handling.Repeat(ctx, 0, func() (done bool, err error) {
198194
// Load data
199-
c.Logger().Debugf("receiving mjpeg frame from %s", source)
200195
encodedFrame, err := r.Receive()
201196
if errors.Is(err, io.EOF) {
202197
c.Logger().Debugf("received eof from %s", source)
@@ -208,7 +203,6 @@ func (h *Handlers) HandleExternalSourcePub() videostreams.HandlerFunc {
208203
}
209204

210205
// Publish data
211-
c.Logger().Debugf("received and publishing frame from %s", source)
212206
c.Publish(encodedFrame)
213207
return false, nil
214208
}),

internal/app/pslive/server.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ func (s *Server) configureLogging(e *echo.Echo) {
8787
}))
8888
e.HideBanner = true
8989
e.HidePort = true
90-
e.Logger.SetLevel(log.DEBUG) // TODO: set level via env var
90+
e.Logger.SetLevel(log.INFO) // TODO: set level via env var
9191
}
9292

9393
// turboDriveStyle is the stylesheet which Turbo Drive tries to install for its progress bar,

0 commit comments

Comments
 (0)