add test coverage for package client

Author: majewsky

internal/client/repo_client_test.go

@@ -0,0 +1,76 @@
+// SPDX-FileCopyrightText: 2026 SAP SE or an SAP affiliate company
+// SPDX-License-Identifier: Apache-2.0
+
+package client_test
+
+import (
+	"io"
+	"testing"
+
+	"github.com/sapcc/go-bits/assert"
+	"github.com/sapcc/go-bits/easypg"
+	"github.com/sapcc/go-bits/must"
+
+	"github.com/sapcc/keppel/internal/client"
+	"github.com/sapcc/keppel/internal/models"
+	"github.com/sapcc/keppel/internal/test"
+)
+
+func TestMain(m *testing.M) {
+	easypg.WithTestDB(m, func() int { return m.Run() })
+}
+
+func TestRepoClientBasic(t *testing.T) {
+	ctx := t.Context()
+	test.WithRoundTripper(func(tt *test.RoundTripper) {
+		s := test.NewSetup(t,
+			test.WithAccount(models.Account{Name: "test1", AuthTenantID: "test1authtenant"}),
+			test.WithQuotas,
+		)
+		const hostName = "registry.example.org"
+		tt.Handlers[hostName] = s.Handler
+		s.AD.ExpectedUserName = "alice"
+		s.AD.ExpectedPassword = "swordfish"
+		s.AD.GrantedPermissions = "pull:test1authtenant,push:test1authtenant"
+
+		rc := &client.RepoClient{
+			Scheme:   "http",
+			Host:     "registry.example.org",
+			RepoName: "test1/foo",
+			UserName: s.AD.ExpectedUserName,
+			Password: s.AD.ExpectedPassword,
+		}
+
+		// test uploading an image using RepoClient
+		img := test.GenerateImage(
+			test.GenerateExampleLayer(1),
+		)
+
+		digest := must.ReturnT(rc.UploadMonolithicBlob(ctx, img.Layers[0].Contents))(t)
+		assert.Equal(t, digest, img.Layers[0].Digest)
+
+		digest = must.ReturnT(rc.UploadMonolithicBlob(ctx, img.Config.Contents))(t)
+		assert.Equal(t, digest, img.Config.Digest)
+
+		digest = must.ReturnT(rc.UploadManifest(ctx, img.Manifest.Contents, img.Manifest.MediaType, "latest"))(t)
+		assert.Equal(t, digest, img.Manifest.Digest)
+
+		// test downloading the same image using RepoClient
+		buf, mediaType, err := rc.DownloadManifest(ctx, models.ManifestReference{Tag: "latest"}, nil)
+		must.SucceedT(t, err)
+		assert.Equal(t, string(buf), string(img.Manifest.Contents))
+		assert.Equal(t, mediaType, img.Manifest.MediaType)
+
+		readCloser, sizeBytes, err := rc.DownloadBlob(ctx, img.Config.Digest)
+		buf = must.ReturnT(io.ReadAll(readCloser))(t)
+		must.SucceedT(t, readCloser.Close())
+		assert.Equal(t, sizeBytes, uint64(len(img.Config.Contents)))
+		assert.Equal(t, string(buf), string(img.Config.Contents))
+
+		readCloser, sizeBytes, err = rc.DownloadBlob(ctx, img.Layers[0].Digest)
+		buf = must.ReturnT(io.ReadAll(readCloser))(t)
+		must.SucceedT(t, readCloser.Close())
+		assert.Equal(t, sizeBytes, uint64(len(img.Layers[0].Contents)))
+		assert.Equal(t, string(buf), string(img.Layers[0].Contents))
+	})
+}

internal/client/upload.go

@@ -23,7 +23,8 @@ func (c *RepoClient) UploadMonolithicBlob(ctx context.Context, contents []byte)
 		Path:   "blobs/uploads/",
 		Query:  url.Values{"digest": []string{d.String()}},
 		Headers: http.Header{
-			"Content-Type": {"application/octet-stream"},
+			"Content-Length": {strconv.FormatUint(uint64(len(contents)), 10)},
+			"Content-Type":   {"application/octet-stream"},
 		},
 		Body:         bytes.NewReader(contents),
 		ExpectStatus: http.StatusCreated,

internal/test/content.go

@@ -95,6 +95,9 @@ func GenerateImage(layers ...Bytes) Image {
 	return GenerateImageWithCustomConfig(nil, layers...)
 }
 
+// GenerateImageWithCustomConfig is like GenerateImage, but allows customizing
+// the contents of the image config. The supplied change function will be called
+// on the default config, and the result will be used as the config blob.
 func GenerateImageWithCustomConfig(change func(map[string]any), layers ...Bytes) Image {
 	config := map[string]any{
 		"architecture": "amd64",