Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow subdomain variations in presentation #992

Open
fcisio opened this issue Feb 23, 2024 · 1 comment
Open

Allow subdomain variations in presentation #992

fcisio opened this issue Feb 23, 2024 · 1 comment

Comments

@fcisio
Copy link

fcisio commented Feb 23, 2024

Hi, I'm using the presentation editor and it seems I have a use case that is not yet supported.

My project has both languages and markets.
https://<market>.domain.com/<language>/pathname

The languages work fine as they are simple path prefixes. But the markets being subdomains is what causes issues.

When inside the editor and navigating to a specific subdomain, I get many obscure errors that don't provide much relevant context.
I do know it's not a DNS or CORS issue.

Describe the solution you'd like

I think the solution would be to add some more options in the presentationTool() plugin. Perhaps a allowedSubdomains array?
If subdomains are defined, there could be a dropdown in the editor to select them.

Describe alternatives you've considered

I have considered implementing alternate logic to pull market data via URL query params, but that's a bit too hacky to my taste.

Additional context

Screenshot 2024-02-23 at 3 07 05 PM
@markomitranic
Copy link

FYI I opened a similar question with some examples here #1280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants