-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Describe the bug
Following the purging of dead letters in #603, and the investigation of those dead letters in #674 - the repeatable dead letter seems to appear on ware-prod: {“flowcell”: …}.
From some investigation, I believe the cause might be due to the message trying to create 1 flowcell, with many lanes, where there is an identical control in each lane.
It might be the the position index should be part of the composite key, for a control, so that the duplicate controls would not be classed as duplicate. However, the position is not currently used in the validation of the control data object, within a flowcell message.
To test this hypothesis, a position could be included in the control data object, or the Unified Warehouse code could be updated to use the lanes position when validating a control.
It might be worth further investigation into whether the exact same control should be allowed in two different lanes, on the same flowcell. If this is a valid scenario (and there are many other duplicate controls across lanes message which have made it to the MLWH successfully), then it would be worth instead looking into why only these messages have been dead lettered, and not other flowcell messages where duplicate controls exist across multiple lanes.
Please see more info in the “flowcell” part of the comment here
Associated Stories
Y25-399-2 - Investigate dead-letter messages since Y25-399
To Reproduce
Steps to reproduce the behaviour:
- Visit
ware-prodRabbitMQ Broker - Look in the
psd.multi-lims-warehouse-consumer.dead-lettersqueue - Find a message with “flowcell” as the high level object
Acceptance Criteria
- Reproduce the dead letter
- Test the above hypothesis
- Create a fix, likely in Sequencescape
- Resubmit flowcell messages and confirm flowcell data is in MLWH
Additional context
Add any other context about the problem here.