You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#75 replaced HWLOC_OBJ_CACHE with HWLOC_OBJ_CACHE_UNIFIED in the hwloc topology code, but this replacement doesn't make sense there since these are values of two different types of enum. See
for an example of where this would be a problem. Since the values for both enums are just the defaults, HWLOC_OBJ_CACHE_UNIFIED has the same binary value as HWLOC_OBJ_MACHINE. In our hwloc detection logic HWLOC_OBJ_CACHE_UNIFIED is frequently cast to type hwloc_obj_type_t which will throw off all the logic around caches throughout the rest of the file since we'll be getting values from functions like hwloc_get_depth_type that correspond to HWLOC_OBJ_MACHINE instead of anything to do with caches.
The text was updated successfully, but these errors were encountered:
#75 replaced
HWLOC_OBJ_CACHE
withHWLOC_OBJ_CACHE_UNIFIED
in the hwloc topology code, but this replacement doesn't make sense there since these are values of two different types of enum. Seeqthreads/src/affinity/hwloc.c
Lines 137 to 141 in f040053
HWLOC_OBJ_CACHE_UNIFIED
has the same binary value asHWLOC_OBJ_MACHINE
. In our hwloc detection logicHWLOC_OBJ_CACHE_UNIFIED
is frequently cast to typehwloc_obj_type_t
which will throw off all the logic around caches throughout the rest of the file since we'll be getting values from functions likehwloc_get_depth_type
that correspond toHWLOC_OBJ_MACHINE
instead of anything to do with caches.The text was updated successfully, but these errors were encountered: