Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asserts Build Config Should Enable Upstream Asserts #155

Closed
insertinterestingnamehere opened this issue Oct 26, 2023 · 1 comment
Closed

Asserts Build Config Should Enable Upstream Asserts #155

insertinterestingnamehere opened this issue Oct 26, 2023 · 1 comment
Labels
enhancement low priority
Milestone
1.22 Release

Comments

@insertinterestingnamehere
Copy link
Collaborator

Just documenting this for now since I'm not sure yet where to make the changes.

There's a build configuration for turning on asserts. It should turn on upstream asserts (e.g. from libstdc++ or libc++) by setting appropriate CFLAGS and/or CXXFLAGS.

I also need to confirm the NDEBUG flag should also be set correctly for non-debug builds too. This avoids pulling in unwanted upstream asserts. That appears to be the case, but I haven't confirmed yet.
@insertinterestingnamehere
Copy link
Collaborator Author

Fixed in #292, although the problem could better be summarized as "non-debug builds should disable asserts in standard headers."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement low priority
Projects
None yet
Milestone
1.22 Release
Development

No branches or pull requests
1 participant
@insertinterestingnamehere