Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: a delete that merely releases override is effectively not undoable #117

Open
frothga opened this issue Jan 9, 2023 · 0 comments
Open

Comments

@frothga
Copy link
Collaborator

frothga commented Jan 9, 2023

Background: Deleting tree items that override inherited values releases the override, so the item now tracks the parent model. (A second delete on the inherited value causes the item to be removed entirely.) Undoing the delete restores the overridden value.

Problem: If the overridden value exactly matches the inherited value, then the undo has no effect, because it runs through a mechanism that removes such overrides. This is only a problem in a particular scenario where you create a child model, update the parent model to match the child, clear overrides in the child model, then decide to undo all of that. The child items continue to track the parent, rather then remaining at their intended values.

The solution is to modify all Delete* UI objects so they bypass the extra override-clearing step when undoing.

It seems unlikely that this is much of a problem in practice, so this is a low-priority issue to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant