Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Equation tree should scroll to edit full height of field #108

Open
frothga opened this issue Apr 3, 2020 · 1 comment
Open

UI: Equation tree should scroll to edit full height of field #108

frothga opened this issue Apr 3, 2020 · 1 comment

Comments

@frothga
Copy link
Collaborator

frothga commented Apr 3, 2020

When font scale (Settings:Look & Feel) is set larger than 1, and edit takes place right at bottom of viewport, equation tree does not scroll far enough to show a full line of the entire cell editor. It is possible to manually scroll (with mouse scroll wheel) during editing, but this is annoying. The cell editor gets inserted at full size, so that is not a problem.

A related problem is that only the first line of the multi-line editor is shown.

Part of the problem is the sequencing in BasicTreeUI.startEditing(). It first scrolls to visible, then determines size of cell editor. To hack around this, we could temporarily set the cell renderer to be the same size as the cell editor.

@frothga frothga added the bug label Apr 3, 2020
@frothga
Copy link
Collaborator Author

frothga commented Apr 3, 2020

Actually, the problem is that when the tree is measuring height of a new cell, the text is empty, so only the icon determines height. Added a hack to put an "M" in temporarily in this case.

Cutting off the bottom of the multi-line editor is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant