Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chord should pass an event to the function callback. #1

Open
ahsteele opened this issue Aug 19, 2013 · 1 comment
Open

Chord should pass an event to the function callback. #1

ahsteele opened this issue Aug 19, 2013 · 1 comment
Labels
enhancement New feature or request

Comments

@ahsteele
Copy link
Member

Chord needs to pass the keyboard event to its function callbacks. The primary use case is the need to event.preventDefault(). Reason for the need to prevent default functionality is when browsers like Firefox do silly things like hijack the forward slash for "quick find": https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly. #sigh

@ghost ghost assigned ahsteele and rheone Aug 19, 2013
rheone added a commit that referenced this issue Aug 20, 2013
Fixing Issue #1 ( #1 )
applying of matched function now provides event information
@rheone
Copy link
Member

rheone commented Aug 20, 2013

Issues taken care of by commit 61927ad8fa7421ff06a7fe4a6fa690f405770da1

Explicit unit testing still required, but event is now available to call back method.

@ahsteele ahsteele reopened this Aug 21, 2013
@rheone rheone removed their assignment Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants