Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyncYAwareness has type inconsistent with implementation. #49

Open
dzfranklin opened this issue Mar 11, 2023 · 0 comments
Open

SyncYAwareness has type inconsistent with implementation. #49

dzfranklin opened this issue Mar 11, 2023 · 0 comments

Comments

@dzfranklin
Copy link

selectLocalAwarenessState: (state: any) => T | undefined will never equal awareness.getStates().entries() mapped to a (BaseAwarenessState & T)[].

I'm guessing that you intended selectLocalAwarenessState to select only the awareness object for the local client, but you're comparing it to list of states for every client.

I'm planning on fixing this in a PR implementing #45 by having two selectors (one for your awareness and one for your view of your peer's awareness)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant