Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't limit TableBasedAuthority#all #319

Open
no-reply opened this issue Jun 17, 2020 · 1 comment
Open

don't limit TableBasedAuthority#all #319

no-reply opened this issue Jun 17, 2020 · 1 comment

Comments

@no-reply
Copy link

authorities with more than 1000 entries have erratic behavior due to

output_set(base_relation.limit(1000))

it seems like it would be good enough to just remove the limit.

@elrayle
Copy link
Contributor

elrayle commented Jan 12, 2021

Rather than remove the limit, I would be inclined to make it configurable. If the configured limit is nil, that can be used to effectively remove the limit.

Change to something like...

    def all
      Qa.config.tablebased_all_limit&.positive? ? output_set(base_relation.limit(1000)) : output_set(base_relation)
    end

The config would default to 1000 to maintain backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Status: Backlog
Development

No branches or pull requests

2 participants