Skip to content

Commit d06b1f9

Browse files
authored
Merge pull request #6704 from samvera/favor-explicit-factory-bot
🧹 Favor explicit FactoryBot.create
2 parents cbb5b4f + 9427f5e commit d06b1f9

7 files changed

+12
-12
lines changed

spec/factories/admin_sets_lw.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757

5858
factory :adminset_lw, class: AdminSet do
5959
transient do
60-
user { create(:user) }
60+
user { FactoryBot.create(:user) }
6161

6262
with_permission_template { false }
6363
with_solr_document { false }
@@ -105,7 +105,7 @@
105105
# Builds a pre-Hyrax 2.1.0 adminset without edit/view grants on the admin set.
106106
# Do not use with create because the save will cause the solr grants to be created.
107107
transient do
108-
user { create(:user) }
108+
user { FactoryBot.create(:user) }
109109
with_permission_template { true }
110110
with_solr_document { true }
111111
end

spec/factories/administrative_sets.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
transient do
1717
with_permission_template { false }
18-
user { create(:user) }
18+
user { FactoryBot.create(:user) }
1919
access_grants { [] }
2020
with_index { true }
2121
end

spec/factories/collections.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@
7474

7575
factory :collection_lw, class: Collection do
7676
transient do
77-
user { create(:user) }
77+
user { FactoryBot.create(:user) }
7878

7979
collection_type { nil }
8080
collection_type_settings { nil }
@@ -135,7 +135,7 @@
135135

136136
factory :user_collection_lw, class: Collection do
137137
transient do
138-
user { create(:user) }
138+
user { FactoryBot.create(:user) }
139139
collection_type { create(:user_collection_type) }
140140
end
141141

@@ -151,7 +151,7 @@
151151
# col = build(:typeless_collection, ...)
152152
# col.save(validate: false)
153153
transient do
154-
user { create(:user) }
154+
user { FactoryBot.create(:user) }
155155
with_permission_template { false }
156156
do_save { false }
157157
end

spec/factories/collections_factory.rb

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
# rubocop:enable Layout/LineLength
1010

1111
transient do
12-
user { create(:user) }
12+
user { FactoryBot.create(:user) }
1313
# allow defaulting to default user collection
1414
collection_type_settings { nil }
1515
with_permission_template { false }
@@ -59,7 +59,7 @@
5959

6060
factory :user_collection, class: Collection do
6161
transient do
62-
user { create(:user) }
62+
user { FactoryBot.create(:user) }
6363
collection_type { create(:user_collection_type) }
6464
end
6565

@@ -75,7 +75,7 @@
7575
# col = build(:typeless_collection, ...)
7676
# col.save(validate: false)
7777
transient do
78-
user { create(:user) }
78+
user { FactoryBot.create(:user) }
7979
with_permission_template { false }
8080
create_access { false }
8181
do_save { false }

spec/factories/file_sets.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
FactoryBot.define do
33
factory :file_set do
44
transient do
5-
user { create(:user) }
5+
user { FactoryBot.create(:user) }
66
content { nil }
77
end
88
after(:build) do |fs, evaluator|

spec/factories/generic_works.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
FactoryBot.define do
44
factory :work, aliases: [:generic_work, :private_generic_work], class: 'GenericWork' do
55
transient do
6-
user { create(:user) }
6+
user { FactoryBot.create(:user) }
77
# Set to true (or a hash) if you want to create an admin set
88
with_admin_set { false }
99
end

spec/factories/hyrax_collection.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
with_permission_template { true }
2020
collection_type { nil }
2121
with_index { true }
22-
user { create(:user) }
22+
user { FactoryBot.create(:user) }
2323
edit_groups { [] }
2424
edit_users { [] }
2525
read_groups { [] }

0 commit comments

Comments
 (0)