Consider Removing #contains=

[tpendragon]

https://github.com/projecthydra-labs/hydra-pcdm/blob/master/lib/hydra/pcdm/models/concerns/object_behavior.rb#L83-L88

[grosscol]

Should object= also be removed? Is this in favor of using a service object to add files to the object?

[elrayle]

RE: objects=

@grosscol, we are moving toward removing the atomic service objects and replacing them with methods as proposed in https://github.com/projecthydra-labs/hydra-pcdm/wiki/Proposed-Interfaces#defining-an-aggregation-with-multiple-filters.

Related to this:

• Proposed new API
• Add filters_association that allow specification of multiple parts within an aggregation samvera-deprecated/activefedora-aggregation#45
• Add << functionality for aggregations samvera-deprecated/activefedora-aggregation#44

[elrayle]

RE: contains=

It appears that this method is never used or tested. Some exploration is required to confirm this. If it is true, then we should be able to safely remove the contains= method.

[escowles]

Should we just deprecate contains= along with the service objects in samvera/hydra-pcdm#144, samvera/hydra-pcdm#158, and #161?

[tpendragon]

@escowles @elrayle Do we have a status here?

[escowles]

I don't have anything new here. But I agree with @elrayle: it doens't look like this is being used or tested. We're overriding it in Hydra::Works::GenericWorkBehavior to throw an error (and that's tested at least). I don't see any usage of it in hydra-pcdm, hydra-works, or curation_concerns.

So I think we should remove it -- whether that's just removing it, deprecating it, etc.

[mjgiarlo]

👍

[mjgiarlo]

Closed by PR.