Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sufia 7.2 migration Reads GenericFile content into memory #3175

Open
carolyncole opened this issue Jun 20, 2017 · 0 comments
Open

Sufia 7.2 migration Reads GenericFile content into memory #3175

carolyncole opened this issue Jun 20, 2017 · 0 comments

Comments

@carolyncole
Copy link
Contributor

Descriptive summary

In Sufia 7.2 Migration the version importer reads the entire content into memory. https://github.com/samvera/sufia/blob/7.2-migration/lib/sufia/import/version_builder.rb#L38

This works fine for small files, but when you start migrating larger files you can run out of memory.

Expected behavior

Stream the file from Fedora instead of doing a single read

Actual behavior

Reads the entire content into memory

Related work

We fixed this in ScholarSphere here: psu-libraries/scholarsphere@8f3f0d1#diff-2897df61a9e8723e3a0f8b8ee15638fcR51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant