Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse everything only attaches files on work create (not edit) #3167

Open
hortongn opened this issue May 9, 2017 · 0 comments
Open

Browse everything only attaches files on work create (not edit) #3167

hortongn opened this issue May 9, 2017 · 0 comments
Labels

Comments

@hortongn
Copy link
Contributor

hortongn commented May 9, 2017

Originally opened as samvera/hyrax#931

Descriptive summary

Attaching cloud files to a work behaves as expected when creating a brand new work. However, if an existing work is edited and the user attempts attach cloud-based files, and exception is thrown upon saving the work. Files are not attached.

We experienced the bug on 7.3.0

Expected behavior

The user should be able to attach cloud files either when creating a work or editing a work.

Actual behavior

Editing and saving an existing work with new cloud-based files attached throws an error.

Steps to reproduce the behavior

  1. Create a work
  2. Edit the work
  3. Add some new files from a cloud provider
  4. Save the work

Related work

University of Cincinnati has fixed this locally here:
https://github.com/uclibs/scholar_uc/pull/1371/files

The fix is in the last line of the partial.

The problem is that when editing a work, browse_everything is looking for a form id of edit_generic_work. However the actual form id has the pid attached (e.g. edit_generic_work_h989r335q)

@hortongn hortongn added the bug label May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant