Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing method for filter_associations :condition should be assumed to be the same as condition returning false #77

Open
elrayle opened this issue Sep 21, 2015 · 1 comment

Comments

@elrayle
Copy link
Contributor

elrayle commented Sep 21, 2015

Example: If a new filter_association is added for a work that has generic_files as members that can be of many different specific classes of generic_files, then each of the specific classes have to implement the condition method. To avoid having to define the condition method multiple times, I propose the following change to the processing of conditions...

FAIL: if it gets ‘method missing’
FAIL: if condition method returns anything but true
PASS: if condition method returns true

@elrayle
Copy link
Contributor Author

elrayle commented Sep 21, 2015

Currently, with 'method missing', the condition processing code raises an error instead of simply failing to pass the condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant