Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19 compatibility? #3

Open
rjp opened this issue Mar 24, 2023 · 4 comments
Open

1.19 compatibility? #3

rjp opened this issue Mar 24, 2023 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rjp
Copy link

rjp commented Mar 24, 2023

Trying to use Lure to proxy to my modded 1.19 server and connecting causes a crash.

Connection to 127.0.0.1:52695 ended with: packet contents were not read completely (802 bytes remain)

rustcord and Ultraviolet have a similar problem which suggests 1.19 may have updated the protocol?

@sammwyy
Copy link
Owner

sammwyy commented Mar 24, 2023

Lure is fully compatible with 1.19, but in the new versions the way that Forge sends the initial packet is different from the vanilla format.

@rjp
Copy link
Author

rjp commented Mar 25, 2023

Ah, I'm guessing that might be the same for Fabric then (not using Forge).

@sammwyy
Copy link
Owner

sammwyy commented Mar 25, 2023

It is possible, to check that the client/server have the same version in mods, these packets are sent outside the vanilla protocol.

I will work on an option to create compatibility.

@sammwyy sammwyy added enhancement New feature or request good first issue Good for newcomers labels Mar 25, 2023
@exalented
Copy link

exalented commented Aug 5, 2023

Lure when connecting to paper server: ended with: unexpected packet ID 1 (expected 3)
Paper server response:

1.20.1-server  | [~ INFO]: com.mojang.authlib.GameProfile@14638cbe[id=<null>,name=notch,properties={},legacy=false] (/meme:49392) lost connection: Disconnected

These are my logs trying to proxy a Fabric 1.20 server:

Accepted connection to ip:41734
Connection to ip:41734 ended with: failed to decode field `profile_id` in `LoginStart`: failed to fill whole buffer
Accepted connection to ip:58712
Connection to ip:58712 ended.
Accepted connection to ip:58714
Connection to ip:58714 ended with: unexpected packet ID 1 (expected 3)
Accepted connection to ip:37692
Connection to ip:37692 ended.
Accepted connection to ip:50054
Connection to ip:50054 ended with: unexpected packet ID 1 (expected 3)
Accepted connection to ip:55068
Connection to ip:55068 ended.
Accepted connection to ip:51644
Connection to ip:51644 ended.
Accepted connection to ip:51656
Connection to ip:51656 ended with: unexpected packet ID 1 (expected 3)
Accepted connection to ip:41280
Connection to ip:41280 ended.
Accepted connection to ip:50232
Connection to ip:50232 ended with: unexpected end of file
Accepted connection to ip:50240
Connection to ip:50240 ended.
Accepted connection to ip:55288
Connection to ip:55288 ended with: unexpected end of file
Accepted connection to ip:59890
Connection to ip:59890 ended.
Accepted connection to ip:49536
Connection to ip:49536 ended with: unexpected end of file

What these have in common is how the server responds, logging id=<null>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants