Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisTooManyMasters in a multi-cluster setup #419

Open
exolab opened this issue May 15, 2024 · 3 comments
Open

RedisTooManyMasters in a multi-cluster setup #419

exolab opened this issue May 15, 2024 · 3 comments

Comments

@exolab
Copy link

exolab commented May 15, 2024

Hi,

We are seeing this alert after deploying multiple Redis clusters in different namespaces. AFAICT Redis itself does not consider this setup a problem.

Does the alert not take this scenario into account, or are we mistaken in thinking we do not have a real problem?

Shouldn't the query be

count(redis_instance_info{role="master"}) by (namespace) > 1 or something similar that takes this scenario into account?

https://github.com/samber/awesome-prometheus-alerts/blame/826be5877ffc129ca3511cd25af87d67ea67fb48/_data/rules.yml#L795

@samber
Copy link
Owner

samber commented May 15, 2024

Hi @exolab and thanks for the report.

Do you have a better label than "namespace" for the cluster differentiation?

Do you know if redis_exporter exposes any cluster name?

@exolab
Copy link
Author

exolab commented May 15, 2024

Maybe by(service) would work. But I am by no means an expert on this.

@DesireWithin
Copy link

DesireWithin commented Oct 7, 2024

Hello @samber ,
I have same issue,
my situation is setup a redis cluster with 3 master and 3 salve.
Each master only handle part of slot:

图片
图片

This rule and RedisDisconnectedSlaves will calculated a wrong result.

How about using this formula to determine the cluster status? redis_cluster_state{%(redisExporterSelector)s} == 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants