fix incorrect endpoints

Author: saltydk

Makefile

@@ -17,7 +17,7 @@ GOVET=$(GOCMD) vet
 BINARY_NAME=sdc
 BINARY_PATH=./cmd/controller
 BUILD_DIR=build
-VERSION?=$(shell git describe --tags --always 2>/dev/null || echo "dev")
+VERSION=0.0.0-dev
 GIT_COMMIT?=$(shell git rev-parse --short HEAD 2>/dev/null || echo "unknown")
 BUILD_TIME?=$(shell date -u +%Y-%m-%dT%H:%M:%SZ)
 

README.md

@@ -164,8 +164,8 @@ SDC will ensure `postgres` and `redis` start first (in parallel), wait for healt
   - Response: `{"message": "Operations are now unblocked"}`
 
 ### Job Status
-- `GET /job_status/{job_id}` - Get job status
-  - Response: `{"status": "pending|running|completed|failed"}`
+- `GET /job_status/{job_id}` - Get job details and status
+  - Response: Full job object with status, results, and timing information
   - Returns `{"status": "not_found"}` with HTTP 404 if job doesn't exist
 
 ### Health

cmd/controller/helper.go

@@ -51,6 +51,7 @@ func runHelper(cmd *cobra.Command, args []string) error {
 
 	// Create client
 	apiClient := client.NewClient(helperConfig.ControllerURL, log)
+	apiClient.SetUserAgent("sdc/" + Version)
 
 	// Wait for controller to become ready
 	log.Info("Waiting for controller to become ready")

internal/api/handlers.go

@@ -170,9 +170,7 @@ func (s *Server) HandleGetJobStatus(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	s.writeJSON(w, http.StatusOK, map[string]string{
-		"status": string(job.Status),
-	})
+	s.writeJSON(w, http.StatusOK, job)
 }
 
 // HandleHealth handles GET /health

internal/client/client.go

@@ -14,9 +14,10 @@ import (
 
 // Client represents an HTTP client for communicating with the controller server
 type Client struct {
-	baseURL    string
+	baseURL   string
 	httpClient *http.Client
-	logger     *logger.Logger
+	logger    *logger.Logger
+	userAgent string
 }
 
 // NewClient creates a new controller client
@@ -26,10 +27,16 @@ func NewClient(baseURL string, logger *logger.Logger) *Client {
 		httpClient: &http.Client{
 			Timeout: 30 * time.Second,
 		},
-		logger: logger,
+		logger:    logger,
+		userAgent: "sdc-client/1.0",
 	}
 }
 
+// SetUserAgent sets a custom User-Agent header for requests
+func (c *Client) SetUserAgent(userAgent string) {
+	c.userAgent = userAgent
+}
+
 // JobRequest represents a request to start or stop containers
 type JobRequest struct {
 	Timeout int      `json:"timeout"`
@@ -38,7 +45,7 @@ type JobRequest struct {
 
 // JobResponse represents a job creation response
 type JobResponse struct {
-	ID     string `json:"id"`
+	ID     string `json:"job_id"`
 	Status string `json:"status"`
 }
 
@@ -105,7 +112,7 @@ func (c *Client) StopContainers(ctx context.Context, timeout int, ignore []strin
 // GetJob retrieves job status and results
 func (c *Client) GetJob(ctx context.Context, jobID string) (*Job, error) {
 	var job Job
-	if err := c.get(ctx, fmt.Sprintf("/jobs/%s", jobID), &job); err != nil {
+	if err := c.get(ctx, fmt.Sprintf("/job_status/%s", jobID), &job); err != nil {
 		return nil, err
 	}
 
@@ -198,6 +205,7 @@ func (c *Client) post(ctx context.Context, path string, body any, result any) er
 	}
 
 	req.Header.Set("Content-Type", "application/json")
+	req.Header.Set("User-Agent", c.userAgent)
 
 	resp, err := c.httpClient.Do(req)
 	if err != nil {
@@ -225,6 +233,8 @@ func (c *Client) get(ctx context.Context, path string, result any) error {
 		return fmt.Errorf("failed to create request: %w", err)
 	}
 
+	req.Header.Set("User-Agent", c.userAgent)
+
 	resp, err := c.httpClient.Do(req)
 	if err != nil {
 		return fmt.Errorf("request failed: %w", err)

internal/client/client_test.go

@@ -88,7 +88,7 @@ func TestClient_GetJob(t *testing.T) {
 	log, _ := logger.New(true)
 
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		assert.Equal(t, "/jobs/test-job-id", r.URL.Path)
+		assert.Equal(t, "/job_status/test-job-id", r.URL.Path)
 		assert.Equal(t, "GET", r.Method)
 
 		job := Job{