Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop IE11 support and CommonJS? #3103

Open
jimmydief opened this issue Mar 16, 2023 · 0 comments
Open

Drop IE11 support and CommonJS? #3103

jimmydief opened this issue Mar 16, 2023 · 0 comments

Comments

@jimmydief
Copy link
Contributor

IE11 was officially retired by Microsoft in June 2022. Would it be possible to update the list of supported targets here?

browsers: ['last 2 versions', 'ie 11'],
node: '8.9.4',

Similarly, the library package on npm includes three different unbundled versions of each component:

  1. Source code in /components
  2. Compiled ES modules in /module/components
  3. Compiled CommonJS modules in /lib/components

There also seem to be several bundled versions of the entire library:

  1. design-system-react-components.js
  2. design-system-react-components.min.js
  3. design-system-react.js
  4. design-system-react.min.js

While decreasing the size of the npm package would certainly be nice, the main reason that it would be nice to consolidate on ESM would be to avoid accidentally duplicating versions of these components in apps which still use a mix of ESM and CommonJS. This is a pretty common footgun which results in increased bundle size as well as bugs when "stateful" things like context or settings are duplicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant