Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding chown functionality to SetInfo request #206

Open
lilybhattacharjee5 opened this issue Jul 9, 2021 · 0 comments
Open

Adding chown functionality to SetInfo request #206

lilybhattacharjee5 opened this issue Jul 9, 2021 · 0 comments

Comments

@lilybhattacharjee5
Copy link

Hello!

A partner and I are working on an internship project that involves using this library in C++ examples that are similar to the library-provided C ones in examples/. One of the functionalities we've implemented is chown for files and directories (seems to be working on our Win32 dev machine, but we need to test more rigorously), and we modified

smb2_encode_set_info_request(struct smb2_context *smb2,
for that because we noticed encode_set_info request didn't seem to support it currently.

Because of the library LGPL license we were wondering if:

  • is this a functionality that you were already planning to add to the library, or does it not belong here?
  • is it ok if we make a PR with the chown addition sometime in the next few weeks? (our company is ok with us sharing this code)
  • should we add tests / C examples?
  • before a PR is merged, is the procedure basically that the new code needs to pass the build checks / be approved by a reviewer? is anything else necessary?

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant