-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMPORTANT ANNOUNCEMENT: About viddy v1.0.0 #117
Comments
By the way, if I switch to Rust, will I have to change this Gopher logo? I really love this logo and don’t want to change it. |
Wow, that's a big change. Thanks for giving the community a heads up! Do you have any plans to make your rust branch public here before the 1.0 release? That would help package maintainers prepare. |
@rrotter Thank you for your comment! |
I've released viddy v1.0.0-rc.1 🎉 |
I've released viddy v1.0.0-rc.2 🎉 |
Big change indeed! I’ll check out the release candidates soon, but as someone who defaults to Go these days for simple programs, I’m curious about your experience with rewriting from Go to Rust. I understand this is somewhat unrelated to the main issue, and you might not be planning to discuss it, but if you are, I’d love to read about it. Thanks! |
Just got a chance to check out v1.0.0-rc.2, seems to work well other than the following --
|
@avamsi Thank you so much! |
Yes, this was an intentional change. The small scroll width was inconvenient, so I will also consider mouse support. Thank you. |
Oh. This is what the Go Version prints for me -- And this is what the Rust version prints --
Looks like I can't upload sqlite files here directly, I put it on Google Drive for now -- https://drive.google.com/file/d/11U-kjxFHC1glvlDpCToNZe2myWUc-uXt/view?usp=drive_link. |
@avamsi Thank you! What is the using OS? |
I'm currently on a Chromebook running Debian (via Crostini), I could test on a MacBook if you want.
Nope. Are you unable to reproduce? What does just |
Ah, I see -- yes, I use Zsh. |
Looks like |
sachaos#117 (comment) viddy currently breaks alignment for commands like `echo '1\t2\n\t3'` as it always adds 4 spaces, this fixes that. One workaround for this is to plumb the command via `expand` (`echo '1\t2\n\t3' | expand`). Go version has the same issue, so this is not a regression.
My pleasure! Thanks for fixing these quickly and in general, your work on viddy -- big fan! |
I have released viddy v1.0.0-rc.3 https://github.com/sachaos/viddy/releases/tag/v1.0.0-rc.3 |
Hi. Thank you very much for your project. Today I try new release v1.0.0-rc3 on centos7 forked system, but it requires new versions of glibc. Maybe is there a way to compile the program for a less recent version of glibc ? |
I have released viddy v1.0.0-rc.5 🎉 |
@slashburygin Thank you for the report! |
Now all is ok, thank you very much. error: invalid value '1.8s' for '--interval ': invalid float literal |
Oh, sorry, now I can set interval without s, for example 1.8 |
@slashburygin Thank you! However, it is a bit difficult to fix because the crate being used cannot handle it. |
The viddy project has switched from Go to Rust: sachaos/viddy#117
I released viddy v1.0.0. I submitted a PR to homebrew-core. |
I close this announcement issue because v1.0.0 released. We will track the status of the package registry in a separate issue. |
I've written the blog post about my experience of migrating from Go to Rust. https://dev.to/sachaos/release-of-viddy-v100-migration-from-go-to-rust-2g41 |
Thanks for the writeup! Matches my experience / expectation trying out Rust here and there but more importantly, it's encouraging to see someone else go through the learning curve / trade offs etc. (and come out the other side)! :) |
Hello everyone,
I am the owner of this project. I am currently working on the development of viddy v1.0.0, which is almost complete and will be released soon.
In a very bold decision, I am going to replace the current viddy, which is written in Go, with Rust. There are several reasons for this, but the main one is that I will be more motivated to maintain it. Additionally, I have been dissatisfied with some aspects of the current implementation of viddy. This is not because of Go, but because my initial implementation was poor. This has led to some of the bugs currently being reported, but I believe a reimplementation will resolve some of them.
Fortunately, viddy has been integrated into many package registries. If a build is required, Rust will be needed, so changes are expected. I apologize for the inconvenience and appreciate your understanding.
In viddy v1.0.0, the following features are planned to be discontinued. If you need these features, please contact me. I will do my best to include them. As for other compatibility, I am making every effort to maintain it as much as possible.
-c
,--clockwork
option--pty
optionThe Rust version of Viddy will be managed in this repository. I apologize to all contributors, but I plan to delete all Go code (it will remain in git). If there are strong objections, I will consider separating the repository or keeping the Go code. Please let me know.
The text was updated successfully, but these errors were encountered: