Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out comment/upload feature from screenshot feature #7

Open
olivierdalang opened this issue Nov 16, 2022 · 0 comments
Open

Factor out comment/upload feature from screenshot feature #7

olivierdalang opened this issue Nov 16, 2022 · 0 comments

Comments

@olivierdalang
Copy link

olivierdalang commented Nov 16, 2022

Hey ! Thanks a lot for this !

In my use case, I do not want to use the screenshoting part, since I already produce my own in my dockerized test suite (by the way, they are animated gifs, not images).

Unfortunately, this makes your action unusable. This is a shame since all the logic about upload service and calling the API works great.

I'd suggest factoring out the upload/comment part to a different action, usable on it's own. I've done this here: https://github.com/opengisch/comment-pr-with-images but of course happy to merge back / collaborate on this if you're interested maintaining a splitted version of your action.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant