Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: btn btn-link btn-disabled looks like button but not link #3216

Open
bogdan opened this issue Sep 22, 2024 · 6 comments
Open

bug: btn btn-link btn-disabled looks like button but not link #3216

bogdan opened this issue Sep 22, 2024 · 6 comments
Labels

Comments

@bogdan
Copy link

bogdan commented Sep 22, 2024

What version of daisyUI are you using?

No response

Which browsers are you seeing the problem on?

All browsers

Reproduction URL

https://play.tailwindcss.com/8cJA9JDvCP

Describe your issue

I believe that when btn btn-link btn-disabled are used together, the result should look like Link but not a button.
While, link-disabled is not currently defined, I believe the fact that these 3 classes can be used together requires to define a style for disabled link.
In practice the disabled link can be used like this:

<div class="tooltip " data-tip="Profile is not yet published" >
  <a href="#" class="link link-disabled">View Public Profile</a>
</div>
Copy link

Thank you @bogdan for reporting issues. It helps daisyUI a lot 💚
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

@saadeghi
Copy link
Owner

How should it look like?

@bogdan
Copy link
Author

bogdan commented Sep 23, 2024

I believe like so:
https://play.tailwindcss.com/00Fv24VDxV

image

@saadeghi saadeghi added the v5 label Oct 31, 2024
@nilaygit-10721
Copy link

can you assign me this issue

@saadeghi
Copy link
Owner

saadeghi commented Nov 5, 2024

Thanks @nilaygit-10721
All issues with v5 tag are already fixed in daisyUI 5 (alpha) or are in progress.
I can't change this style in daisyUI 4 because this visual change is a breaking change and it will effect all the existing apps who are relying on the previous behavior.

daisyUI 5 will be released soon after Tailwind CSS 4

@tats-u
Copy link

tats-u commented Nov 21, 2024

So is btn-ghost: #3285

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants