Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TODO] Review secret key expiration check #25

Open
mkarg opened this issue Dec 31, 2020 · 2 comments
Open

[TODO] Review secret key expiration check #25

mkarg opened this issue Dec 31, 2020 · 2 comments
Labels
on hold Wait until something else will be done.

Comments

@mkarg
Copy link
Contributor

mkarg commented Dec 31, 2020

There are questions open wrt to how we currently perform the expiration check for the secret key, see bcgit/bc-java#861. Once this issue is resolved, we possibly need to revise our existing solution.
@mkarg mkarg added the bug Something isn't working. label Dec 31, 2020
@mkarg
Copy link
Contributor Author

mkarg commented Dec 31, 2020

In case we actually did the check unsafe, this would be a bug, so I marked this issue as bug pro-forma, as we do not have label for either "todo" or "possible bug".

@slawekjaranowski
Copy link
Member

you can add more labels here https://github.com/s4u/.github/blob/master/.github/labels.yml
and assign new labels to release category https://github.com/s4u/.github/blob/master/common-files/.github/release-drafter.yml

@mkarg mkarg added todo Assigned and will be done. and removed bug Something isn't working. labels Jan 1, 2021
@slawekjaranowski slawekjaranowski added on hold Wait until something else will be done. and removed todo Assigned and will be done. labels Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
on hold Wait until something else will be done.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mkarg @slawekjaranowski