Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added windows support #8

Closed
wants to merge 1 commit into from
Closed

added windows support #8

wants to merge 1 commit into from

Conversation

ekinertac
Copy link

@ekinertac ekinertac commented Aug 27, 2024 •
edited by coderabbitai bot
Loading

fixes: #6

Summary by CodeRabbit

  • New Features

    • Enhanced development environment with expanded permissions for system-level and network access.
    • Improved server startup logic with OS-specific feedback and conditional tunnel management.

  • Bug Fixes

    • Ensured proper server lifecycle management and execution flow.

@ryoppippi
Copy link
Owner

ryoppippi commented Aug 27, 2024 •
edited
Loading

@ekinertac
Thank you for your contribution!
looks like windows does not use wrangler anymore?
If so, please add instruction message for windows user!
(if you can, |'m happy that you write a new instruction for windows users on README.md)

Also, I allowed CI execution, and some of them fails!
Please run commands in https://github.com/ryoppippi/curxy/blob/main/.github/workflows/ci.yaml before commitiing!

@ryoppippi ryoppippi marked this pull request as draft August 27, 2024 09:39
@ryoppippi ryoppippi marked this pull request as ready for review August 27, 2024 09:39
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 27, 2024 •
edited
Loading

Walkthrough

The changes involve modifications to the deno.json configuration and the main.ts file. The dev task command in deno.json has been updated to include additional permissions, allowing for enhanced system and network access. In main.ts, the server startup logic has been revised to improve management and provide OS-specific feedback, ensuring the tunnel is only started when appropriate.

Changes

Files Change Summary
deno.json Updated dev task command to include --allow-sys --allow-net.
main.ts Revised server startup logic to manage the server lifecycle and provide OS-specific feedback.

Assessment against linked issues

Objective Addressed Explanation
Cannot run on Windows (#6) ✅
Provide OS-specific feedback during startup ✅

🐰 In fields of code, I hop and play,
With permissions granted, I seize the day!
A tunnel to the clouds, oh what a sight,
Windows now smiles, everything feels right!
So let’s run our servers, let them gleam,
In the world of Deno, we’ll chase our dream! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Aug 27, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 135d6ef and 0481d9c.

Files ignored due to path filters (1)
  • deno.lock is excluded by !**/*.lock
Files selected for processing (2)
  • deno.json (1 hunks)
  • main.ts (2 hunks)
Additional comments not posted (3)
deno.json (1)

6-6: LGTM! Ensure no security risks with additional permissions.

The inclusion of --allow-sys and --allow-net permissions is necessary for the application to run smoothly on Windows. Ensure that these permissions do not introduce any security risks.

The code changes are approved.

main.ts (2)

73-74: LGTM!

The server is now started first and assigned to a variable server, improving the management of the server's lifecycle.

The code changes are approved.

Line range hint 75-97: LGTM!

The conditional check for the operating system provides OS-specific feedback and ensures that the tunnel is only started when appropriate.

The code changes are approved.

@ryoppippi
Copy link
Owner

@ekinertac
Hi! Please check my comments!

@ryoppippi
Copy link
Owner

Close this because I added a flag to disable cloudflared.
Thanks for your work @ekinertac

@ryoppippi ryoppippi closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

@ekinertac ekinertac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run on windows
2 participants
@ekinertac @ryoppippi