Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist feature doesn't work on ios #1093

Open
rootux opened this issue Oct 22, 2023 · 2 comments
Open

Playlist feature doesn't work on ios #1093

rootux opened this issue Oct 22, 2023 · 2 comments
Assignees
Labels
1 backlog bug Something isn't working

Comments

@rootux
Copy link

rootux commented Oct 22, 2023

Which API doesn't behave as documented, and how does it misbehave?
Only on iOS (Works on Android)
When trying to use the playlist feature.
upon calling await _playlist.addAll(audios);
The player jumps directly to the next song instead of queuing it in the playlist.

Minimal reproduction project
Provide a link here using one of two options:

  1. Forked the repository - link here - https://github.com/rootux/just_audio/blob/minor/just_audio/example/lib/example_playlist.dart
  2. "The example"

To Reproduce (i.e. user steps, not code)
Steps to reproduce the behavior:

1. Start the playlist example - https://github.com/rootux/just_audio/blob/minor/just_audio/example/lib/example_playlist.dart
2. Run on IOS (Android works)
3. Click on Play
4. Click rapidly on + to add new items to the playlist
5. observe that the playlist "jumps" and doesn't play fluently

Expected behavior
Expecting the playlist to finish playing current song and then jump to the next one without any skips.

Smartphone (please complete the following information):

  • Device: iPad 2021

Flutter SDK version

flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.13.7, on macOS 13.4 22F66 darwin-arm64, locale en-IL)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.2)
[✓] IntelliJ IDEA Ultimate Edition (version 2023.1.2)
[✓] VS Code (version 1.79.1)
[✓] Connected device (2 available)
[✓] Network resources

• No issues found!

Additional context
This happens only for the assets audio source that's why I kept the nature sounds.
For me (Not in the example) this happens when I'm using BufferAudioSource.

class BufferAudioSource extends StreamAudioSource {
  BufferAudioSource(this._buffer) : super(tag: "buffered_audio");

  final Uint8List _buffer;

  @override
  Future<StreamAudioResponse> request([int? startIndex, int? endIndex]) {
    final start = startIndex ?? 0;
    final end = endIndex ?? _buffer.length;

    return Future.value(
      StreamAudioResponse(
        sourceLength: _buffer.length,
        contentLength: end - start,
        offset: start,
        contentType: 'audio/mpeg',
        stream:
            Stream.value(List<int>.from(_buffer.skip(start).take(end - start))),
      ),
    );
  }
}
@rootux rootux added 1 backlog bug Something isn't working labels Oct 22, 2023
@github-actions
Copy link

Oops, it appears that your issue did not follow the template and is missing one or more required sections. Please open a new issue, and provide all required sections and information.

FAQ:

  1. Do I really need to submit a minimal reproduction project for a bug? A: Yes. I prioritise bugs secondarily on how many people are affected, and primarily on whether the bug report is complete, in the sense that it enables me to immediately reproduce it and start working on a fix. If a bug is important to you, the best thing you can do is to provide all requested information ASAP so that I can start looking into it ASAP.

  2. I think I supplied all required information, so did the bot make a mistake? A: The bot only checks the section headings, so when you post a new issue, make sure you leave the section headings intact. (Note that because of this, it is even possible to trick the bot by including only the section headings, and then not providing the requested information under each heading. This is frowned upon, and the issue will be closed manually.)

Copy link

github-actions bot commented Nov 8, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs, or use StackOverflow if you need help with just_audio.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2023
@ryanheise ryanheise reopened this Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 backlog bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants