-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit Module Broken in Production Mode #14
Comments
Crap, it was a bug in the Globalize unit runtime module: globalizejs/globalize@1d2f977 (I'm considering a 1.1.1 patch release providing this fix). Globalize examples need improvement and your help would be very much appreciated. 👊 By the way, react-globalize could be handy for you: usage example. It's worthy to note FormatUnit (the component for unit formatting) isn't implemented yet, would you be interested in implementing it? |
Globalize 1.1.1 released with such fix. Please could you retry using the newer version? Thx |
http://aruberto.github.io/globalize-webpack-test/#/unit It seems to be working now, thx! I might be able to update docs in coming weeks, just building this demo example cause trying to proof of concept i18n options for an app at work. I also plan on trying react-globalize + react-globalize-webpack-compiler next. |
Excellent, looking forward to it. If you find any problems just let me know. |
Wrote a simple app to test this webpack plugin - https://github.com/aruberto/globalize-webpack-test
However I'm running into problem with unit formatter. The page with my unit formatter examples (click here http://aruberto.github.io/globalize-webpack-test/#/unit) throws the following error:
The secondFormatter reffered to in error is from following line of source code in https://github.com/aruberto/globalize-webpack-test/blob/master/src/components/unit/index.js:
When run in DEV mode, the unit module works correctly and the page loads fine.
Also all the other formatters work correctly in PROD mode (example http://aruberto.github.io/globalize-webpack-test/#/number)
The text was updated successfully, but these errors were encountered: