Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you accept a PR that made the pcap-parser turned into async Rust? #47

Closed
MichaelScofield opened this issue Dec 6, 2024 · 1 comment

Comments

@MichaelScofield
Copy link

as title

@chifflier
Copy link
Member

Hi,
I am not sure moving to async-only would be a good move. At the moment, one possible thing would be to make the crate async-compatible (maybe using a feature?), but I'd like not to force all dependencies to become async.

This is only a first feedback, and I'm open to debate. If there are strong arguments I do not know, please add them to this discussion. I'd also be interested in discussing if you have some experience with async, because my first experiments for pcaps were quite dissatisfying, yet I think I am to blame for the lack of knowledge and the poor choices of design for my async tests.

@MichaelScofield MichaelScofield closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants