Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade pprof to 0.14 to fix https://github.com/rusticata/pcap-parser/issues/46 #17942

Merged
merged 1 commit into from
Dec 5, 2024
Merged

*: upgrade pprof to 0.14 to fix https://github.com/rusticata/pcap-parser/issues/46 #17942

merged 1 commit into from
Dec 5, 2024

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Dec 5, 2024 •
edited
Loading

What is changed and how it works?

Issue Number: ref #15990, close rusticata/pcap-parser#46.

What's Changed:

upgrade pprof to 0.14 to fix https://github.com/rusticata/pcap-parser/issues/46.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Dec 5, 2024
This was referenced Dec 5, 2024
Merged
Closed
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 5, 2024
Connor1996
Connor1996 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 5, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, hbisheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-05 10:02:17.348176639 +0000 UTC m=+1321924.967831155: ☑️ agreed by hbisheng.
  • 2024-12-05 10:04:49.146060366 +0000 UTC m=+1322076.765714878: ☑️ agreed by Connor1996.

@ti-chi-bot ti-chi-bot bot merged commit 004490c into tikv:master Dec 5, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot added this to the Pool milestone Dec 5, 2024
@LykxSassinator LykxSassinator deleted the upgrade_pprof branch December 5, 2024 10:42
@LykxSassinator LykxSassinator added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 9, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Dec 9, 2024
@LykxSassinator @ti-chi-bot
This is an automated cherry-pick of tikv#17942
397e397 
fix rusticata/pcap-parser#46, close rusticata/pcap-parser#46, ref tikv#15990

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 9, 2024
Closed
9 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #17960.

LykxSassinator added a commit to ti-chi-bot/tikv that referenced this pull request Dec 9, 2024
@LykxSassinator
CP tikv#17942.
c59f416 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator LykxSassinator added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Dec 11, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #17978.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Dec 11, 2024
@LykxSassinator @ti-chi-bot
This is an automated cherry-pick of tikv#17942
2a3910f 
fix rusticata/pcap-parser#46, close rusticata/pcap-parser#46, ref tikv#15990

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 11, 2024
Closed
9 tasks
LykxSassinator added a commit to ti-chi-bot/tikv that referenced this pull request Dec 11, 2024
@LykxSassinator
Merge tikv#17942.
e979136 
Signed-off-by: lucasliang <[email protected]>
nicolaslopezbravo pushed a commit to nicolaslopezbravo/tikv that referenced this pull request Jan 9, 2025
@LykxSassinator
*: upgrade pprof to 0.14 to fix rusticata/pcap-parser#46 (tikv#17942)
728cf76 
close rusticata/pcap-parser#46, fix rusticata/pcap-parser#46, ref tikv#15990

upgrade pprof to 0.14 to fix rusticata/pcap-parser#46.

Signed-off-by: lucasliang <[email protected]>
nicolaslopezbravo pushed a commit to nicolaslopezbravo/tikv that referenced this pull request Jan 9, 2025
@LykxSassinator
*: upgrade pprof to 0.14 to fix rusticata/pcap-parser#46 (tikv#17942)
78fde4b 
close rusticata/pcap-parser#46, fix rusticata/pcap-parser#46, ref tikv#15990

upgrade pprof to 0.14 to fix rusticata/pcap-parser#46.

Signed-off-by: lucasliang <[email protected]>
Signed-off-by: nbravo <[email protected]>
nicolaslopezbravo pushed a commit to nicolaslopezbravo/tikv that referenced this pull request Jan 9, 2025
@LykxSassinator
*: upgrade pprof to 0.14 to fix rusticata/pcap-parser#46 (tikv#17942)
039cfe6 
close rusticata/pcap-parser#46, fix rusticata/pcap-parser#46, ref tikv#15990

upgrade pprof to 0.14 to fix rusticata/pcap-parser#46.

Signed-off-by: lucasliang <[email protected]>
nicolaslopezbravo pushed a commit to nicolaslopezbravo/tikv that referenced this pull request Jan 9, 2025
@LykxSassinator
*: upgrade pprof to 0.14 to fix rusticata/pcap-parser#46 (tikv#17942)
5f2ce37 
close rusticata/pcap-parser#46, fix rusticata/pcap-parser#46, ref tikv#15990

upgrade pprof to 0.14 to fix rusticata/pcap-parser#46.

Signed-off-by: lucasliang <[email protected]>
nicolaslopezbravo pushed a commit to nicolaslopezbravo/tikv that referenced this pull request Jan 9, 2025
@LykxSassinator
*: upgrade pprof to 0.14 to fix rusticata/pcap-parser#46 (tikv#17942)
6627785 
close rusticata/pcap-parser#46, fix rusticata/pcap-parser#46, ref tikv#15990

upgrade pprof to 0.14 to fix rusticata/pcap-parser#46.

Signed-off-by: lucasliang <[email protected]>
nicolaslopezbravo pushed a commit to nicolaslopezbravo/tikv that referenced this pull request Jan 9, 2025
@LykxSassinator
*: upgrade pprof to 0.14 to fix rusticata/pcap-parser#46 (tikv#17942)
a35a54a 
close rusticata/pcap-parser#46, fix rusticata/pcap-parser#46, ref tikv#15990

upgrade pprof to 0.14 to fix rusticata/pcap-parser#46.

Signed-off-by: lucasliang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Connor1996 Connor1996 Connor1996 approved these changes

@hbisheng hbisheng hbisheng approved these changes

@overvenus overvenus Awaiting requested review from overvenus

@glorv glorv Awaiting requested review from glorv

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Pool
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2024-0408: Unsound usages of std::slice::from_raw_parts
4 participants
@LykxSassinator @ti-chi-bot @hbisheng @Connor1996