Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Add scancode conversions from Chromium sources #4020

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Dec 1, 2024

Similar to #4019, but for Windows.

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

@madsmtm madsmtm added S - enhancement Wouldn't this be the coolest? DS - windows labels Dec 1, 2024
@madsmtm madsmtm requested a review from notgull as a code owner December 1, 2024 20:00
@madsmtm madsmtm force-pushed the madsmtm/windows-scancode-chromium branch from 278f11d to e4cf352 Compare December 2, 2024 12:11
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, rebase and I will merge

@madsmtm madsmtm merged commit 164bf85 into master Dec 3, 2024
58 checks passed
@madsmtm madsmtm deleted the madsmtm/windows-scancode-chromium branch December 3, 2024 10:05
@madsmtm
Copy link
Member Author

madsmtm commented Dec 3, 2024

I went and did the merge myself ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DS - windows S - enhancement Wouldn't this be the coolest?
Development

Successfully merging this pull request may close these issues.

2 participants